[PATCH] D148110: [clang-tidy] Ctor arguments are sequenced if ctor call is written as list-initialization.

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 13 11:07:22 PDT 2023


njames93 added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1163
 
+namespace {
+
----------------
Whats with this namespace addition? looks unnecessary and should be removed


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1206
+  {
+    // TODO: Note that this is a regression test.
+    A a;
----------------
Whats with the todo comment, surery a comment explaining that this shouldn't trigger a warning should suffice


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148110/new/

https://reviews.llvm.org/D148110



More information about the cfe-commits mailing list