[PATCH] D148245: Model list initialization more directly; fixes an assert with coverage mapping

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 13 09:13:53 PDT 2023


aaron.ballman created this revision.
aaron.ballman added reviewers: erichkeane, rsmith, zequanwu.
Herald added a subscriber: martong.
Herald added a reviewer: shafik.
Herald added a project: All.
aaron.ballman requested review of this revision.
Herald added a project: clang.

Instead of using the validity of a brace's source location as a flag for list initialization, this now uses a `PointerIntPair` to model it so we do not increase the size of the AST node to track this information. This allows us to retain the valid source location information, which fixes the coverage assertion.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D148245

Files:
  clang/docs/ReleaseNotes.rst
  clang/include/clang/AST/ExprCXX.h
  clang/lib/AST/ASTImporter.cpp
  clang/lib/AST/ExprCXX.cpp
  clang/lib/Sema/SemaExprCXX.cpp
  clang/lib/Serialization/ASTReaderStmt.cpp
  clang/lib/Serialization/ASTWriterStmt.cpp
  clang/test/Coverage/unresolved-ctor-expr.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148245.513272.patch
Type: text/x-patch
Size: 9663 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230413/66e6f1ed/attachment.bin>


More information about the cfe-commits mailing list