[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 13 05:56:02 PDT 2023


erichkeane added inline comments.


================
Comment at: clang/test/CodeGenCXX/defaulted_equality_ignore_unnamed_bitfields.cpp:23
+
+// If it compares the unnamed bitfields it will first compare the named bit-field
+// and then branch based on the result of that comparison.
----------------
I think these check lines aren't nearly specific enough, i think it should have a handful of CHECK lines confirming what we're doing, not just what we're not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146329/new/

https://reviews.llvm.org/D146329



More information about the cfe-commits mailing list