[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 12 18:03:02 PDT 2023


MaskRay added a comment.

Unfortunately we cannot do this. `LLVMSupport` depends on `LLVMDemangle`. Due to library layering `LLVMDemangle` cannot depend on `LLVMSupport`.
The layering may look weird, but that's what we have.

Using `std::string_view` may possibly be fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148181/new/

https://reviews.llvm.org/D148181



More information about the cfe-commits mailing list