[PATCH] D140315: [AMDGCN] Update search path for device libraries

[Harald van Dijk via Phabricator via cfe-commits]

hvdijk added a comment.

In D140315#4077611 <https://reviews.llvm.org/D140315#4077611>, @scchan wrote:

> In D140315#4076614 <https://reviews.llvm.org/D140315#4076614>, @mgorny wrote:
>
>> I'm sorry for reporting it this late (clang's been broken for over two weeks, so we couldn't periodically test it) but this change is causing test regressions on Gentoo/amd64:
>
> Thanks for reporting the issue.  I'm working on a patch to fix the test.

I don't think it's actually the test that was at fault, it doesn't look right that this diff uses `CLANG_INSTALL_LIBDIR_BASENAME` for an unrelated purpose to determining the basename of the libdir, especially considering the comments continue to say clang looks in `lib/amdgcn/bitcode` rather than `<LIBDIR>/amdgcn/bitcode`, and your original test specifically assumed that it would always be `lib`. Should the code perhaps just be updated to hardcode `"lib"` as it did before?

Either way, the test can still fail after D142506 <https://reviews.llvm.org/D142506>, `CLANG_INSTALL_LIBDIR_BASENAME` may be any arbitrary string and cannot be assumed to be either `lib` or `lib64`. With Debian-style multiarch I have `CLANG_INSTALL_LIBDIR=lib/x86_64-linux-gnu`, so after updating from Clang 15 to Clang 16 I am now also seeing this test fail.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140315/new/

https://reviews.llvm.org/D140315