[PATCH] D144331: [libc++][format] Implements formatter thread::id.

[Manoj Gupta via Phabricator via cfe-commits]

manojgupta added a comment.

Just a heads up, with this change, we are hitting issues in building gdb. Appreciate any ideas on what is wrong.

  aarch64-cros-linux-gnu-clang++ -x c++    -I. -I. -I./config -DLOCALEDIR="\"/usr/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode   -I../bfd -I./../bfd -I./../include -I../libdecnumber -I./../libdecnumber  -I./../gnulib/import -I../gnulib/import -I./.. -I..  -DTUI=1    -I./.. -pthread  -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-error=maybe-uninitialized -Wno-mismatched-tags -Wno-error=deprecated-register -Wsuggest-override -Wimplicit-fallthrough=3 -Wduplicated-cond -Wshadow=local -Wdeprecated-copy -Wdeprecated-copy-dtor -Wredundant-move -Wmissing-declarations -Wmissing-prototypes -Wstrict-null-sentinel -Wformat -Wformat-nonliteral  -Os -pipe -march=armv8-a+crc+crypto -ftree-vectorize -g -ffunction-sections -fdata-sections     -c -o minsyms.o -MT minsyms.o -MMD -MP -MF ./.deps/minsyms.Tpo minsyms.c
   In file included from minsyms.c:56:
   In file included from ./../gdbsupport/parallel-for.h:25:
   In file included from /usr/bin/../include/c++/v1/thread:100:
   In file included from /usr/bin/../include/c++/v1/__format/formatter_integral.h:32:
   In file included from /usr/bin/../include/c++/v1/locale:203:
   /usr/bin/../include/c++/v1/__locale:600:5: error: '__abi_tag__' attribute only applies to structs, variables, functions, and namespaces
       _LIBCPP_INLINE_VISIBILITY
       ^
   /usr/bin/../include/c++/v1/__config:668:37: note: expanded from macro '_LIBCPP_INLINE_VISIBILITY'
   #  define _LIBCPP_INLINE_VISIBILITY _LIBCPP_HIDE_FROM_ABI
                                       ^
   /usr/bin/../include/c++/v1/__config:647:26: note: expanded from macro '_LIBCPP_HIDE_FROM_ABI'
             __attribute__((__abi_tag__(_LIBCPP_TOSTRING(_LIBCPP_VERSIONED_IDENTIFIER))))
                            ^
   In file included from minsyms.c:56:
   In file included from ./../gdbsupport/parallel-for.h:25:
   In file included from /usr/bin/../include/c++/v1/thread:100:
   In file included from /usr/bin/../include/c++/v1/__format/formatter_integral.h:32:
   In file included from /usr/bin/../include/c++/v1/locale:203:
   /usr/bin/../include/c++/v1/__locale:601:37: error: expected ';' at end of declaration list
       char_type toupper(char_type __c) const
                                       ^
   /usr/bin/../include/c++/v1/__locale:607:48: error: too many arguments provided to function-like macro invocation
       const char_type* toupper(char_type* __low, const char_type* __high) const
                                                  ^
   ./../include/safe-ctype.h:146:9: note: macro 'toupper' defined here
   #define toupper(c) do_not_use_toupper_with_safe_ctype
           ^
   In file included from minsyms.c:56:
   In file included from ./../gdbsupport/parallel-for.h:25:
   In file included from /usr/bin/../include/c++/v1/thread:100:
   In file included from /usr/bin/../include/c++/v1/__format/formatter_integral.h:32:
   In file included from /usr/bin/../include/c++/v1/locale:203:
   /usr/bin/../include/c++/v1/__locale:619:48: error: too many arguments provided to function-like macro invocation
       const char_type* tolower(char_type* __low, const char_type* __high) const
                                                  ^
   ./../include/safe-ctype.h:148:9: note: macro 'tolower' defined here
   #define tolower(c) do_not_use_tolower_with_safe_ctype
           ^

Contents of __locale at line 600:

  _LIBCPP_INLINE_VISIBILITY
  char_type toupper(char_type __c) const
  {
      return do_toupper(__c);
  }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144331/new/

https://reviews.llvm.org/D144331