[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 12 11:56:51 PDT 2023
aaron.ballman added a comment.
Thank you! I think there's only a few small things left then:
- Add a release note about the fact that we worked around this issue in non-asserts builds but that assert builds may see new assertions triggered from this and to file an issue with a reproducer if you hit the assertion.
- File an issue with a simple reproducer for the case you know we're still not handling properly
- Update the commit message to clarify that we're no longer fixing anything with these changes but are instead trying to catch the issues are more loudly than with a crash
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147073/new/
https://reviews.llvm.org/D147073
More information about the cfe-commits
mailing list