[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199
Corentin Jabot via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 12 10:42:35 PDT 2023
cor3ntin added inline comments.
================
Comment at: clang/test/CXX/drs/dr18xx.cpp:172-227
+namespace dr1894 { // dr1894: 3.8
+ // NB: reusing dr407 test
+ struct S;
+ typedef struct S S;
+ void f() {
+ struct S *p;
+ {
----------------
Endill wrote:
> cor3ntin wrote:
> > I think i would prefer reusing verbatim the example in 1894 - lines 207 and following basically - as the issue clearly state that what comes before is resolved by 407 so not really relevant here
> Does the same apply to 2199? It also contains examples resolved by 407.
Yes, i think so. That way it better shows what is actually resolved / tested - amd avoid to much duplication
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148136/new/
https://reviews.llvm.org/D148136
More information about the cfe-commits
mailing list