[PATCH] D147969: Add InsertBraces to ChromiumStyle
Björn Schäpers via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 11 12:15:44 PDT 2023
HazardyKnusperkeks added inline comments.
================
Comment at: clang/lib/Format/Format.cpp:1699
ChromiumStyle.DerivePointerAlignment = false;
+ ChromiumStyle.InsertBraces = true;
if (Language == FormatStyle::LK_ObjC)
----------------
MyDeveloperDay wrote:
> This is an code modifying feature, we agreed that all code modifying features would be off by default, opt in only
Now the question arises if //default// simply only applies to `LLVMStyle`, since that's the //default// when nothing is stated, or if other styles are free to enable such features in their style //by default//.
I'd say if chromium wants to do that, they should be allowed to.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147969/new/
https://reviews.llvm.org/D147969
More information about the cfe-commits
mailing list