[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

Tue Apr 11 11:27:39 PDT 2023

cor3ntin added a comment.

In D148029#4258800 <https://reviews.llvm.org/D148029#4258800>, @shafik wrote:

> Do we have a test that covers valid doxygen comments? I was looking and I don't see an obvious one.

AFAICT, some in `CommentTextTest.cpp` - not that many though.

================
Comment at: clang/lib/Sema/Sema.cpp:2404
       break;
+    case RawComment::RCK_Invalid:
+      // FIXME: are there other scenarios that could produce an invalid
----------------
shafik wrote:
> I don't get why we don't have to handle the other `RawComment` cases here.
Because they can't be `isAlmostTrailingComment` - which checks whether you forgot an additional `*` or `/`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148029/new/

https://reviews.llvm.org/D148029