[PATCH] D147839: [clang] Add test for CWG2007
Vlad Serebrennikov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 11 10:29:04 PDT 2023
Endill added a comment.
In D147839#4258681 <https://reviews.llvm.org/D147839#4258681>, @shafik wrote:
> In D147839#4257394 <https://reviews.llvm.org/D147839#4257394>, @Endill wrote:
>
>> Replace unary `&` with `__builtin_addressof()`. It prevents unnecessary template instantiation (presumably to find overloaded unary `&`), and make Clang compliant since 3.4
>
> Nice approach!
Credits go to Aaron, actually. We discussed this DR during his office hours yesterday.
In D147839#4258682 <https://reviews.llvm.org/D147839#4258682>, @shafik wrote:
> LGTM, thank you again for all the effort in documenting these and adding tests, it is much appreciated.
Thank you for giving them thorough review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147839/new/
https://reviews.llvm.org/D147839
More information about the cfe-commits
mailing list