[PATCH] D147848: [clang] Add test for CWG2370

Tue Apr 11 10:07:44 PDT 2023

shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: clang/test/CXX/drs/dr23xx.cpp:182
+  typedef N::type N_type;
+  // FIXME: `type` should be searched for in N
+  // friend void N::g(type);
----------------
Endill wrote:
> shafik wrote:
> > The implementation seems to all accept this example: https://godbolt.org/z/vE6bEP6xa
> > 
> > but the examples from the `p1787` have a decidely mixed conformance: https://godbolt.org/z/dhq7oEKaY
> > 
> > but the `A::F(F)` you point out in your example clang does get wrong and gcc does not. So at minimum please file bug reports against the examples that clang does not get right from `p1787` and we need to dig into why your example above seems to not the same since that is what you intended. 
> Are you sure behavior is different for my `N::g(type)` when compared to `A::f(F)`? Clang is the only one to reject both examples: https://godbolt.org/z/MKb6fE8K5
Oh wow, I someone how missed the commented line of code and thought you were referring to the uncomment line.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147848/new/

https://reviews.llvm.org/D147848