[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.
Zequan Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 11 09:11:45 PDT 2023
zequanwu added a comment.
In D147073#4258396 <https://reviews.llvm.org/D147073#4258396>, @aaron.ballman wrote:
> In D147073#4258384 <https://reviews.llvm.org/D147073#4258384>, @hans wrote:
>
>> Again not an expert here, but lgtm.
>>
>> (Nit: the https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaExprCXX.cpp#L1528-L1530 link in the description seems to point to the wrong code now, since main changed. Here is a link for 16.0.1: https://github.com/llvm/llvm-project/blob/llvmorg-16.0.1/clang/lib/Sema/SemaExprCXX.cpp#L1536)
>
> I'm confused -- I thought D147569 <https://reviews.llvm.org/D147569> resolved the issue and so this patch is no longer needed?
D147569 <https://reviews.llvm.org/D147569> fixes https://github.com/llvm/llvm-project/issues/45481. This one fixes another issue crbug.com/1427933. Their stack trace look similar but not caused by the same issue.
Updated the link in summary to: https://github.com/llvm/llvm-project/blob/llvmorg-16.0.1/clang/lib/Sema/SemaExprCXX.cpp#L1536
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147073/new/
https://reviews.llvm.org/D147073
More information about the cfe-commits
mailing list