[PATCH] D147989: [clang] Fix Attribute Placement
Priyanshi Agarwal via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 11 06:24:19 PDT 2023
ipriyanshi1708 added a comment.
In D147989#4257721 <https://reviews.llvm.org/D147989#4257721>, @aaron.ballman wrote:
> Thank you for working on this!
>
> The changes are missing test coverage; please be sure to add that, along with a release note about the fix. I think there's likely more work to be done here as well, considering this behavior: https://godbolt.org/z/sdK3Gef75 (notice the suggested location for the fix-it -- that also needs to be fixed for this)
Thanks for reviewing. I am working on tests now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147989/new/
https://reviews.llvm.org/D147989
More information about the cfe-commits
mailing list