[PATCH] D147962: [RFC][clang] Pull experimental targets' info out of TargetInfo.cpp (NFC)

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 11 06:01:51 PDT 2023


aaron.ballman added reviewers: rjmccall, efriedma.
aaron.ballman added a comment.

Adding the codegen code owners for their approval, but in general I think this is a good idea.



================
Comment at: clang/lib/CodeGen/ABIInfoImpl.h:33-52
+bool isAggregateTypeForABI(QualType T);
+
+llvm::Type *getVAListElementType(CodeGenFunction &CGF);
+
+CGCXXABI::RecordArgABI getRecordArgABI(const RecordType *RT, CGCXXABI &CXXABI);
+
+CGCXXABI::RecordArgABI getRecordArgABI(QualType T, CGCXXABI &CXXABI);
----------------
Because we're sort of elevating these from implementation details hidden in the .cpp to interfaces exposed via a header file, we should probably document these functions better (not needed as part of this change though).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147962/new/

https://reviews.llvm.org/D147962



More information about the cfe-commits mailing list