[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

Tue Apr 11 02:29:59 PDT 2023

sammccall added inline comments.

================
Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:77
+
+void escape(char C, llvm::raw_ostream &OS) {
+  switch (C) {
----------------
xazax.hun wrote:
> We already sort of have a way to escape HTML here: https://github.com/llvm/llvm-project/blob/132f1d31fd66c30baf9773bf8f37b36a40fa7039/clang/include/clang/Rewrite/Core/HTMLRewrite.h#L60
> 
> I think we should reuse that (and potentially extend it if it does not fit our needs).
Yeah, we have this in a bunch of places.

The canonical one looks like llvm::printHTMLEscaped in Support, switched to that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146591/new/

https://reviews.llvm.org/D146591