[PATCH] D144510: [clang-tidy] improve readability-identifier-naming hungarian options test

[Douglas Chen via Phabricator via cfe-commits]

dougpuob added a comment.

In D144510#4256258 <https://reviews.llvm.org/D144510#4256258>, @amurzeau wrote:

> In D144510#4254959 <https://reviews.llvm.org/D144510#4254959>, @dougpuob wrote:
>
>> Hi @amurzeau
>>
>> I missed the review before landing. I have a suggestion regarding the customized prefix "cust" because it confused me when I found the Hungarian notation patterns in the output message. Perhaps using "my" instead of "cust" would improve readability.
>>
>> Take some examples:
>>
>> - const char *`custszNamePtr` = "Name"; --> `myszNamePtr`
>> - uint8_t `custu8ValueU8` = 0; --> `myu8ValueU8`
>> - DWORD `custdwMsDword` = 0; --> `mydwMsDword`
>
> Hi,
>
> Yes this is a good idea, m and y are less used as type prefixes.
>
> Do you want to make the change ? I can do it if you want.

Thank you. I will send a patch for the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144510/new/

https://reviews.llvm.org/D144510