[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

Alex Bradbury via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 10 11:53:24 PDT 2023


asb accepted this revision.
asb added a comment.

In D146463#4255927 <https://reviews.llvm.org/D146463#4255927>, @paulkirth wrote:

> @asb  Are we happy with the state of consensus w.r.t. using `x3`? I think the lingering concerns from the psABI discussion have been resolved.

Yes, all LGTM now.



================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2062
   const llvm::Triple &Triple = TC.getTriple();
-  // Default small data limitation is eight.
-  const char *SmallDataLimit = "8";
+  // Default small data limitation on some platforms(Android and Fuchsia) is
+  // zero, otherwise its eight.
----------------
Nit: Missing space after platforms


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146463/new/

https://reviews.llvm.org/D146463



More information about the cfe-commits mailing list