[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

Mon Apr 10 11:15:50 PDT 2023

philnik added inline comments.

================
Comment at: libcxx/include/__type_traits/is_equality_comparable.h:46
 template <class _Tp, class _Up>
-struct __is_trivially_equality_comparable
+struct __libcpp_is_trivially_equality_comparable
     : integral_constant<bool,
----------------
Mordante wrote:
> philnik wrote:
> > Mordante wrote:
> > > This does not magically use the builtin right? Does the patch miss that parts that use the builtin or is that a followup? If it's a followup I would prefer move the libc++ code changes of this patch to a separate review.
> > No, it doesn't magically use the builtin. I plan to do that in a follow-up. These changes are required though, since clang grabs the name with this patch.
> But it would still be possible to have these libc++ changes in a separate review and commit them separately. I would say the libc++ changes are quite trivial and can be landed quite quickly.
See D147953

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147175/new/

https://reviews.llvm.org/D147175