[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

Mon Apr 10 10:42:25 PDT 2023

nickdesaulniers added a comment.

In D147714#4253247 <https://reviews.llvm.org/D147714#4253247>, @xbolva00 wrote:

>>> I'm curious if folks have pursued @efriedma 's suggestion #2 from https://github.com/llvm/llvm-project/issues/54964#issuecomment-1101612886?
>
> This is something we mentioned here, perform target specific checks in Sema (but still it is not possible to catch everything in Sema!)
>
> But the problem of strict musttail call maker stays here. So either we have to relax musttail or create new one.

(After reading more sources to see where musttail fails: https://github.com/llvm/llvm-project/issues/54964#issuecomment-1500708651)

I'm not against a new one, but I'll retain my "Changes Requested" on this patch until the UX is fixed. Restating:

> So at the very least, this should use the existing clang support for backend diagnostics rather than crashing. Please see how !srcloc works for inline asm and __attribute__((warning(""))). It should be straightforward to attach that ad-hoc metadata to call sites with that statement attribute.

Do not crash the compiler like this.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147714/new/

https://reviews.llvm.org/D147714