[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

[Christopher Di Bella via Phabricator via cfe-commits]

cjdb added a comment.

I have no opinion on this addition. If folks find it useful in GCC, happy to see it added.



================
Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1139
+    return 7;
+  return 0;
+}
----------------
I'd prefer this to be an assert rather than returning a value. We should never be able to return from here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147875/new/

https://reviews.llvm.org/D147875