[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

Vassil Vassilev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 9 06:15:12 PDT 2023


v.g.vassilev added inline comments.


================
Comment at: clang/lib/Interpreter/Interpreter.cpp:383
+
+static std::string MangleName(ASTContext &C, GlobalDecl GD) {
+  std::unique_ptr<MangleContext> MangleC(C.createMangleContext());
----------------
I suspect we could use `IncrementalParser::GetMangledName` which in turn uses codegen's caching. In that case we could avoid having a dtor cache altogether and move all of the logic inside the RuntimeInterfaceBuilder.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141215/new/

https://reviews.llvm.org/D141215



More information about the cfe-commits mailing list