[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

Piotr Zegar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 9 03:28:02 PDT 2023


PiotrZSL added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:706
+size_t IdentifierNamingCheck::HungarianNotation::getAsteriskCount(
+    std::string &TypeName, const NamedDecl *ND) const {
+  size_t PtrCount = 0;
----------------
const std::string&


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:294-296
+- Fix hungarian notation issue in :doc:`readability-identifier-naming
+  <clang-tidy/checks/readability/identifier-naming>` which failed to indicate
+  the number of asterisks.
----------------
this list should by sorted by a full check name, also there are already fixes for readability-identifier-naming, check if you could merge this to them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147779/new/

https://reviews.llvm.org/D147779



More information about the cfe-commits mailing list