[PATCH] D146904: [clang-tidy] Fix extern fixes in readability-redundant-declaration

Piotr Zegar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 8 08:10:52 PDT 2023


PiotrZSL added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/redundant-declaration.cpp:126
+extern "C" int externX;
+int dumyBegin;extern "C" int externX;int dummyEnd;
+// CHECK-MESSAGES: :[[@LINE-1]]:30: warning: redundant 'externX' declaration [readability-redundant-declaration]
----------------
carlosgalvezp wrote:
> Typo: dummy
> 
> I don't quite see why these are needed to test the example in PR42068?
I wasn't sure about getLocForEndOfToken, so just wanted to add some tokens before and after, to be 100% sure that they wont be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146904/new/

https://reviews.llvm.org/D146904



More information about the cfe-commits mailing list