[PATCH] D147534: [clang][Interp] Make sure we have a variable scope for initializers

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 7 08:19:49 PDT 2023


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Generally LGTM but had an additional test request.



================
Comment at: clang/test/AST/Interp/records.cpp:315
+      auto T = Test(Arr, Pos);
+      // End of scope, should destroy Test.
+    }
----------------
Would it make sense to give `Test` a constexpr destructor so that we can validate it's being called? e.g. https://godbolt.org/z/fhE7xzE4e


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147534/new/

https://reviews.llvm.org/D147534



More information about the cfe-commits mailing list