[PATCH] D147535: [clang][Interp] Don't create global variables more than once
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 7 07:41:41 PDT 2023
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I keep trying to find some way to test this change... and instead, I've filed several new crashing issues in the issue tracker. The changes look correct to me despite the lack of a test, but if anyone else can dream up some way to tell a ctor is being called twice instead of once, that would be great. If not, LGTM otherwise.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147535/new/
https://reviews.llvm.org/D147535
More information about the cfe-commits
mailing list