[PATCH] D147673: [Clang] Improve designated inits diagnostic location

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 6 18:01:54 PDT 2023


shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.

Thank you for taking care of this, LGTM



================
Comment at: clang/lib/Sema/SemaInit.cpp:2646
+          if (Loc.isInvalid())
+            // This could happen with a "null" designator (i.e. an anonymous
+            // union/struct). Do our best to approximate the location.
----------------
nitpick, I think the comment should be above the `if` statement


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147673/new/

https://reviews.llvm.org/D147673



More information about the cfe-commits mailing list