[PATCH] D147742: [python] Enable bindings tests on Windows
Artur Ryt via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 6 13:56:16 PDT 2023
R2RT created this revision.
R2RT added a project: clang.
Herald added a project: All.
R2RT requested review of this revision.
Herald added a subscriber: cfe-commits.
Unlike stated by removed comment, they do simply pass in my local enviroment.
In order to find necessary fixes (if any), CI has to run these tests.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D147742
Files:
clang/bindings/python/tests/CMakeLists.txt
Index: clang/bindings/python/tests/CMakeLists.txt
===================================================================
--- clang/bindings/python/tests/CMakeLists.txt
+++ clang/bindings/python/tests/CMakeLists.txt
@@ -28,12 +28,6 @@
set(RUN_PYTHON_TESTS FALSE)
endif()
-# Tests fail on Windows, and need someone knowledgeable to fix.
-# It's not clear whether it's a test or a valid binding problem.
-if(WIN32)
- set(RUN_PYTHON_TESTS FALSE)
-endif()
-
# The Python FFI interface is broken on AIX: https://bugs.python.org/issue38628.
if(${CMAKE_SYSTEM_NAME} MATCHES "AIX")
set(RUN_PYTHON_TESTS FALSE)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147742.511519.patch
Type: text/x-patch
Size: 610 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230406/7098a551/attachment.bin>
More information about the cfe-commits
mailing list