[PATCH] D147732: [AMDGPU] Add f32 permlane{16, x16} builtin variants

Stanislav Mekhanoshin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 6 12:30:09 PDT 2023


rampitec added a comment.

In D147732#4249584 <https://reviews.llvm.org/D147732#4249584>, @jrbyrnes wrote:

> In D147732#4249567 <https://reviews.llvm.org/D147732#4249567>, @rampitec wrote:
>
>> Isn't it simpler to lower it to an existing int intrinsic and casts in clang?
>
> Thanks for your comment Stas!
>
> I think it would be ideal if clang inserted pure bitcasts for floats instead of fptoui when passed as operands to these builtins. My concern is -- Do you think we need to preserve the implicit casting behavior for compatibility?

You can manually lower builtin to a proper cast and intrinsic in the CGBuiltin.cpp.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147732/new/

https://reviews.llvm.org/D147732



More information about the cfe-commits mailing list