[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

Thu Apr 6 10:02:21 PDT 2023

ilya-biryukov added a comment.

Sorry for taking so long to land this, it fell off my radar.

In D146971#4227482 <https://reviews.llvm.org/D146971#4227482>, @aaron.ballman wrote:

> LGTM, though the change should come with a release note. Suggestion you can take or leave as you see fit: should we turn the places where we removed the null pointer check into assertions that the pointer is nonnull? Or are we hoping the crash will be sufficient to tell us when we've missed a case?

Added the check. I think they're useful, at the very least if folks hit them they a better chance of finding this change and reaching out to the right people.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146971/new/

https://reviews.llvm.org/D146971