[clang] 385bcc6 - Revert "[clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR."

Francesco Petrogalli via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 5 11:55:40 PDT 2023


Author: Francesco Petrogalli
Date: 2023-04-05T20:55:08+02:00
New Revision: 385bcc65ff44d9860572ee85adb5df1333860a05

URL: https://github.com/llvm/llvm-project/commit/385bcc65ff44d9860572ee85adb5df1333860a05
DIFF: https://github.com/llvm/llvm-project/commit/385bcc65ff44d9860572ee85adb5df1333860a05.diff

LOG: Revert "[clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR."

This reverts commit 029212617ca8bdedd949d17bf2d33750605ea607.

Reverting because of failures when setting
`CLANG_CRASH_DIAGNOSTICS_DIR` before invoking `ninja check-clang`.

Added: 
    

Modified: 
    clang/test/lit.cfg.py

Removed: 
    


################################################################################
diff  --git a/clang/test/lit.cfg.py b/clang/test/lit.cfg.py
index 7c5a55c8e313..e9bfaf2e9677 100644
--- a/clang/test/lit.cfg.py
+++ b/clang/test/lit.cfg.py
@@ -284,10 +284,6 @@ def exclude_unsupported_files_for_aix(dirname):
         config.substitutions.append(('llvm-nm', 'env OBJECT_MODE=any llvm-nm'))
         config.substitutions.append(('llvm-ar', 'env OBJECT_MODE=any llvm-ar'))
 
-# Pass the crash diagnostic dir set in the os environment to LIT.
-if 'CLANG_CRASH_DIAGNOSTICS_DIR' in os.environ:
-    config.environment['CLANG_CRASH_DIAGNOSTICS_DIR'] = os.environ['CLANG_CRASH_DIAGNOSTICS_DIR']
-
 # It is not realistically possible to account for all options that could
 # possibly be present in system and user configuration files, so disable
 # default configs for the test runs.


        


More information about the cfe-commits mailing list