[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

Wed Apr 5 11:52:54 PDT 2023

fpetrogalli added a comment.

In D147209#4246622 <https://reviews.llvm.org/D147209#4246622>, @leonardchan wrote:

> In D147209#4245229 <https://reviews.llvm.org/D147209#4245229>, @fpetrogalli wrote:
>
>> In D147209#4244615 <https://reviews.llvm.org/D147209#4244615>, @leonardchan wrote:
>>
>>> Hi. I think this led to some test failures on our builder at https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8784708268307261009/overview:
>>
>> Hi @leonardchan - thank you for the heads up!
>>
>> I do not have access to this bot (the link you sent just shows me a blank page), and I have not seen this (clang?) test failing in my local build. I can revert the patch, but I'll need some more info to be able to fix those failures.
>>
>> Francesco
>
> Hmm, that's interesting since the link should be public and normally doesn't just appear as blank. Does it still show up as blank if you click it again? Otherwise I can share the full repro. I think you should be able to reproduce this if you define `CLANG_CRASH_DIAGNOSTICS_DIR` as an environment variable before running `ninja check-clang`.

yep - still a white page for me...

Anyway, thank you for the suggestion - I managed to reproduce the issue (for example, `FAIL: Clang :: Driver/crash-report.cpp (93 of 17575)`), I'll revert and submit a new patch with the fix.

Francesco

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147209/new/

https://reviews.llvm.org/D147209