[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

[Thorsten via Phabricator via cfe-commits]

tschuett added inline comments.


================
Comment at: clang/lib/Interpreter/Interpreter.cpp:198
+// These better to put in a runtime header but we can't. This is because we
+// can't find the percise resource directory in unittests so we have to hard
+// code them.
----------------
precise


================
Comment at: clang/lib/Interpreter/Interpreter.cpp:578
+
+class RuntimeInterfaceBuilder
+    : public TypeVisitor<RuntimeInterfaceBuilder, Interpreter::InterfaceKind> {
----------------
https://llvm.org/docs/CodingStandards.html#anonymous-namespaces


================
Comment at: clang/lib/Interpreter/Value.cpp:27
+
+namespace {
+
----------------
https://llvm.org/docs/CodingStandards.html#anonymous-namespaces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141215/new/

https://reviews.llvm.org/D141215