[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

[Leonard Chan via Phabricator via cfe-commits]

leonardchan added a comment.

Hi. I think this led to some test failures on our builder at https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8784708268307261009/overview:

  Script:
  --
  : 'RUN: at line 4';   rm -rf /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/crmdir
  : 'RUN: at line 5';   mkdir -p /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/crmdir/i /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/crmdir/m
  : 'RUN: at line 7';   env FORCE_CLANG_DIAGNOSTICS_CRASH= TMPDIR=/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/crmdir TEMP=/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/crmdir TMP=/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/crmdir  not /b/s/w/ir/x/w/staging/llvm_build/bin/clang -fsyntax-only /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/crash-report-modules.m -I /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/module -isysroot /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/crash-report-modules.m.tmp/i/                  -fmodules -fmodules-cache-path=/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/crmdir/m/ -DFOO=BAR 2>&1 | /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/crash-report-modules.m
  : 'RUN: at line 11';   /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck --check-prefix=CHECKSRC /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/crash-report-modules.m -input-file /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/crmdir/crash-report-*.m
  : 'RUN: at line 12';   /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck --check-prefix=CHECKSH /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/crash-report-modules.m -input-file /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/crmdir/crash-report-*.sh
  --
  Exit Code: 2
  
  Command Output (stderr):
  --
  Could not open input file '/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/crmdir/crash-report-*.m': No such file or directory
  --

I think perhaps since we define `CLANG_CRASH_DIAGNOSTICS_DIR` as an env, tests that produce crash reports place them there, but those tests also expect the crash report to be in a temp dir `%T`, so perhaps some tests need to be updated along side this? Would you be able to take a look and fix or revert?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147209/new/

https://reviews.llvm.org/D147209