[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.
Vassil Vassilev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 4 08:51:59 PDT 2023
v.g.vassilev added inline comments.
================
Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:288
+ }
+ for (auto &SpecInfo : LazySpecializations) {
+ Record.push_back(SpecInfo.DeclID);
----------------
We should not store the lazy specialization information as an array of items because that makes the search slow. Instead we should use the `OnDiskHashTable` approach which we use already to store the identifier data.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D41416/new/
https://reviews.llvm.org/D41416
More information about the cfe-commits
mailing list