[PATCH] D147495: [Clang][Attributes] Add MeaningfulToClassTemplateDefinition to unavailable attribute

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 4 05:03:14 PDT 2023


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, though please add a release note about the fix. I don't *think* this qualifies as a potentially breaking change, though it does theoretically have the ability to cause code which previously compiled to no longer compile. At least, my search over sourcegraph didn't come up with any results (https://sourcegraph.com/search?q=context:global+lang:C%2B%2B+-file:.*test.*+template+%3Ctypename%7Cclass+.*%3E+__attribute__%5C%28%5C%28unavailable&patternType=regexp&sm=1&groupBy=repo).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147495/new/

https://reviews.llvm.org/D147495



More information about the cfe-commits mailing list