[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 3 15:49:23 PDT 2023


jansvoboda11 added inline comments.


================
Comment at: clang/test/Modules/implicit-private-with-submodule-explicit.m:9
+// RUN: %clang_cc1 -x objective-c -fmodules -fno-implicit-modules -emit-module -fmodule-name=A_Private %t/module.modulemap -o %t/A_Private.pcm
+// RUN: %clang_cc1 -x objective-c -verify -fmodules -fno-implicit-modules -fmodule-file=A=%t/A.pcm -fmodule-file=A_Private=%t/A_Private.pcm -fsyntax-only %t/tu.m
+
----------------
Can we also test the `-fmodule-file=<path>` mode? I assume it doesn't go through the changed code path, but having extra test coverage could be useful.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147477/new/

https://reviews.llvm.org/D147477



More information about the cfe-commits mailing list