[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

Sun Apr 2 03:50:45 PDT 2023

xen0n marked 2 inline comments as done.
xen0n added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:41
 /// so we provide a rough mapping here.
 std::string Linux::getMultiarchTriple(const Driver &D,
                                       const llvm::Triple &TargetTriple,
----------------
xen0n wrote:
> SixWeining wrote:
> > xen0n wrote:
> > > SixWeining wrote:
> > > > Missing test. Perhaps add some in `clang/test/Driver/linux-ld.c` and `clang/test/Driver/linux-header-search.cpp`? Or postpone this change until loongarch is upstreamed to Debian?
> > > Thanks, I'll try adding the tests in the next revision.
> > > 
> > > But given [[ https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028654 | the recent reversal of upstream dpkg support ]] (apparently due to miscommunication) it may be prudent to wait until a consensus is reached Debian-side.
> > [[ https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=9dfffbbae | The multiarch tuples have been upstreamed to dpkg ]].  I think we can amend the change and move on now.
> Sorry for the delay in processing this, I've updated the code to reflect the latest spec change. I'll still have to check the unit-test part though.
I've now added tests for the Debian sysroot layout, based on Revy's latest work.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142688/new/

https://reviews.llvm.org/D142688