[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

Emilia Dreamer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 31 05:22:51 PDT 2023


rymiel added inline comments.


================
Comment at: clang/docs/tools/dump_format_style.py:72
 
-  subtype, napplied = re.subn(r'^std::vector<(.*)>$', r'\1', typestr)
-  if napplied == 1:
-    return 'List of ' + pluralize(to_yaml_type(subtype))
+  match = re.match(r'std::vector<(.*)>$', typestr)
+  if match:
----------------
jp4a50 wrote:
> I changed this from `subn` to `match` here since it's just a simpler way of expressing the same thing.
(Just FYI, those pythons sources are pretty ancient and untouched, I planned on refactoring the whole thing using more modern, idiomatic Python but then concluded that it's not really necessary)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146101/new/

https://reviews.llvm.org/D146101



More information about the cfe-commits mailing list