[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro
Congcong Cai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 30 08:56:33 PDT 2023
HerrCai0907 added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:70
+ File.data() + LocInfo.second, File.end());
+ L.SetCommentRetentionState(WithComment);
+ // Find the token.
----------------
This part of code copy from `Lexer::findNextToken` except this line. Should I refactor `Lexer::findNextToken` for example add a parameter to control it?
But `Lexer::findNextToken` is involved with lots of code. Maybe use another patch to do it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147194/new/
https://reviews.llvm.org/D147194
More information about the cfe-commits
mailing list