[PATCH] D146376: Update static_assert message for redundant cases

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 30 06:41:32 PDT 2023


tbaeder added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16718
 void Sema::DiagnoseStaticAssertDetails(const Expr *E) {
-  if (const auto *Op = dyn_cast<BinaryOperator>(E)) {
+  if (const auto *Op = dyn_cast<BinaryOperator>(E);Op && Op->getOpcode() != BO_LOr) {
     const Expr *LHS = Op->getLHS()->IgnoreParenImpCasts();
----------------
This line is over 80 colums now, remember to format it: https://llvm.org/docs/Contributing.html#format-patches


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146376/new/

https://reviews.llvm.org/D146376



More information about the cfe-commits mailing list