[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing
Manuel Klimek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 30 01:58:58 PDT 2023
klimek added a comment.
I apologize for not tagging appropriately - is that process documented somewhere?
Herald added a comment.
NOTE: Clang-Format Team Automated Review Comment
It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test (unless this is an `NFC` or refactoring, adding documentation etc..)
Add you unit tests in `clang/unittests/Format` and build `ninja FormatTests` we recommend using the `verifyFormat(xxx)` format of unit tests rather than `EXPECT_EQ` as this will ensure you change is tolerant to random whitespace changes (see FormatTest.cpp as an example)
For situations where your change is altering the TokenAnnotator.cpp which can happen if you are trying to improve the annotation phase to ensure we are correctly identifying the type of a token, please add a token annotator test in `TokenAnnotatorTest.cpp`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147176/new/
https://reviews.llvm.org/D147176
More information about the cfe-commits
mailing list