[PATCH] D147111: [clang-format] Add MinDigits suboptions to IntegerLiteralSeparator

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 29 17:28:34 PDT 2023


owenpan requested review of this revision.
owenpan marked an inline comment as done.
owenpan added inline comments.


================
Comment at: clang/include/clang/Format/Format.h:4299
            InsertNewlineAtEOF == R.InsertNewlineAtEOF &&
            IntegerLiteralSeparator.Binary == R.IntegerLiteralSeparator.Binary &&
+           IntegerLiteralSeparator.BinaryMinDigits ==
----------------
HazardyKnusperkeks wrote:
> Could we move that to (a not yet existing) `IntegerLiteralSeparatorStyle::operator==`?
Good point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147111/new/

https://reviews.llvm.org/D147111



More information about the cfe-commits mailing list