[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables
Takuya Shimizu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 29 17:00:02 PDT 2023
hazohelet added a comment.
In D146358#4230122 <https://reviews.llvm.org/D146358#4230122>, @simideveloper wrote:
> hey, I was working on the same issue so can we collaborate on this issue?
@simideveloper Thanks for your interest in collaborating on this issue, and sorry if I discouraged you from contributing by working on the same problem.
I assume this patch is in the its final stage, awaiting feedback on wording. However, there's more room for improvement around the uninitialized subobject diagnostics of clang, and your experience working on this issue could be helpful in resolving those issues.
One example of further improvement:
struct Type1 { int val; }; // note emitted
struct Derived {
Type1 val; // we could note on this as well
constexpr Derived(){}
};
constexpr Derived D;
Link: https://godbolt.org/z/v3rhz88aM
I am open to future collaboration opportunities as well. Happy hacking!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146358/new/
https://reviews.llvm.org/D146358
More information about the cfe-commits
mailing list