[PATCH] D147003: [clang-format] JSON Add ability to add a space before the colon

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added inline comments.


================
Comment at: clang/lib/Format/TokenAnnotator.cpp:4155
     if (Right.is(tok::colon))
-      return false;
+      return Style.SpaceBeforeJsonColon;
   } else if (Style.isCSharp()) {
----------------
owenpan wrote:
> MyDeveloperDay wrote:
> > owenpan wrote:
> > > Do we need to check if `Left.is(tok::string_literal)`?
> > Hmm... maybe... I guess I was thinking all colons in JSON are to the right of string literals? 
> I think you're right. Please ignore my comment then, or maybe add an assertion if you like.
you know what you pursued me lets go defensive and check anyway. Just incase an IDE is in the middle of editing when a save occurs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147003/new/

https://reviews.llvm.org/D147003