[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

Wed Mar 29 12:11:37 PDT 2023

royjacobson marked an inline comment as done.
royjacobson added a comment.

In D146168#4231457 <https://reviews.llvm.org/D146168#4231457>, @aaron.ballman wrote:

> LGTM aside from a minor nit, though I have some minor concerns that we may silently break people's code by calling different overloads or instantiating templates differently so I wonder if this is a potentially breaking change or not. I think we can leave it out of the potentially breaking changes section unless we get some reports about a behavior change organically during this release cycle?

My rule of thumb here is since we change behavior to match other compilers it's probably not too disruptive.

================
Comment at: clang/lib/Sema/SemaExprCXX.cpp:1138
     if (C.isCopyCapture()) {
-      ClassType.removeLocalCVRQualifiers(Qualifiers::CVRMask);
-      if (!CurLSI->Mutable)
+        if (!CurLSI->Mutable)
         ClassType.addConst();
----------------
aaron.ballman wrote:
> This looks like an accidental formatting mistake that can be backed out.
ah, thanks for catching it!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146168/new/

https://reviews.llvm.org/D146168