[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py
Piotr Zegar via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 29 10:26:53 PDT 2023
PiotrZSL updated this revision to Diff 509411.
PiotrZSL added a comment.
Remove change added by mistake
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146875/new/
https://reviews.llvm.org/D146875
Files:
clang-tools-extra/clang-tidy/add_new_check.py
Index: clang-tools-extra/clang-tidy/add_new_check.py
===================================================================
--- clang-tools-extra/clang-tidy/add_new_check.py
+++ clang-tools-extra/clang-tidy/add_new_check.py
@@ -138,9 +138,9 @@
if (!MatchedDecl->getIdentifier() || MatchedDecl->getName().startswith("awesome_"))
return;
diag(MatchedDecl->getLocation(), "function %%0 is insufficiently awesome")
- << MatchedDecl;
- diag(MatchedDecl->getLocation(), "insert 'awesome'", DiagnosticIDs::Note)
+ << MatchedDecl
<< FixItHint::CreateInsertion(MatchedDecl->getLocation(), "awesome_");
+ diag(MatchedDecl->getLocation(), "insert 'awesome'", DiagnosticIDs::Note);
}
} // namespace clang::tidy::%(namespace)s
@@ -275,7 +275,7 @@
module, check_name + '.' + test_extension))
print('Creating %s...' % filename)
with io.open(filename, 'w', encoding='utf8', newline='\n') as f:
- f.write("""// RUN: %%check_clang_tidy %%s %(check_name_dashes)s %%t
+ f.write("""// RUN: %%check_clang_tidy %%s %(check_name_dashes)s %%t --
// FIXME: Add something that triggers the check here.
void f();
@@ -293,7 +293,7 @@
def get_actual_filename(dirname, filename):
- if not os.path.isdir(dirname):
+ if not os.path.isdir(dirname):
return ''
name = os.path.join(dirname, filename)
if (os.path.isfile(name)):
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146875.509411.patch
Type: text/x-patch
Size: 1362 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230329/5c297b96/attachment.bin>
More information about the cfe-commits
mailing list