[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 29 10:06:07 PDT 2023
Eugene.Zelenko added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/utils/ExceptionSpecAnalyzer.cpp:83
+ DefaultableMemberKind Kind) {
+ auto *RecType = Base.getType()->getAs<RecordType>();
+ if (!RecType)
----------------
Should be `const auto *`.
================
Comment at: clang-tools-extra/clang-tidy/utils/ExceptionSpecAnalyzer.cpp:87
+
+ auto *BaseClass = cast<CXXRecordDecl>(RecType->getDecl());
+
----------------
Ditto.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146922/new/
https://reviews.llvm.org/D146922
More information about the cfe-commits
mailing list