[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

Wed Mar 29 08:15:40 PDT 2023

dang added a comment.

You will need to rebase this as I made some changes recently to how `ExtractAPIVisitor` is structured. We can either set up a time to talk about it and do it together or I can handle doing this work once we are happy with this.

================
Comment at: clang/lib/ExtractAPI/ExtractAPIVisitor.cpp:52
+template <typename T>
+void modifyRecord(const T &Records, const llvm::StringRef &name) {
+  for (const auto &Record : Records) {
----------------
this should be a marked `static` or put in an anonymous namespace.

================
Comment at: clang/lib/ExtractAPI/ExtractAPIVisitor.cpp:56
+      Record.second.get()->Declaration.removeLast();
+      Record.second.get()
+          ->Declaration
----------------
I think this warrants adding methods to declaration fragments to streamline this sort of operation (merging fragments at arbitrary offsets. This should probably be done as a follow up patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146385/new/

https://reviews.llvm.org/D146385