[PATCH] D146376: Update static_assert message for redundant cases
Timm Bäder via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 29 03:31:34 PDT 2023
tbaeder added inline comments.
================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16732
+ // Ignore BO_LOr operators at the toplevel.
+ if (Op->getOpcode() == BO_LOr)
+ return;
----------------
tbaeder wrote:
> You can just drop the comment and move this into the `if` statement above, e..g `if (...; BO && BO->getOpcode() != BO_Lor)`.
I was talking about the one that checks that `E` is a `BinaryOperator`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146376/new/
https://reviews.llvm.org/D146376
More information about the cfe-commits
mailing list